Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package vadiminshakov/committer #5545

Merged
merged 1 commit into from
Dec 28, 2024

Conversation

vadiminshakov
Copy link
Contributor

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

  • [+] The repo documentation has a pkg.go.dev link.
  • [-] The repo documentation has a coverage service link.
  • [+] The repo documentation has a goreportcard link.
  • [+] The repo has a version-numbered release and a go.mod file.
  • [+] The repo has a continuous integration process that automatically runs tests that must pass before new pull requests are merged.
  • [+] Continuous integration is used to attempt to catch issues prior to releasing this package to end-users.

Please provide some links to your package to ease the review

Pull Request content

  • [+] The package has been added to the list in alphabetical order.
  • [+] The package has an appropriate description with correct grammar.
  • [+] As far as I know, the package has not been listed here before.

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

  • [+] The packages around my addition still meet the Quality Standards.

Thanks for your PR, you're awesome! 😎

Copy link

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

  • repo link
  • pkg.go.dev
  • goreportcard.com
  • coverage

Your project is under review. It may take a few days to be approved.

@phanirithvij
Copy link
Collaborator

Readme says MIT, project has Apache license.

Code coverage or testing required. Please re-read the quality guidelines

@vadiminshakov
Copy link
Contributor Author

@phanirithvij

fixed readme.

Code coverage or testing required

The project has a badge for the test pipeline. I haven’t added test coverage yet because, due to the specifics of the project, it contains significantly more integration tests than unit tests, which would result in a misleadingly low coverage level.

@phanirithvij phanirithvij merged commit cb2b0c9 into avelino:main Dec 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants